Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app_rpt.c: Add RPT_ALINKS and RPT_NUMALINKS #289

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Conversation

tsawyer
Copy link
Member

@tsawyer tsawyer commented Mar 5, 2024

Thanks to ASL2 PR by mkmer

RPT_ALINKS and RPT_NUMALINKS are not initialized at startup. Once a remote node connects/disconnects the vars become available. Until a connection, MANY errors to be logged like this: WARNING[627] ast_expr2.fl: ast_yyerror(): syntax error: syntax error, unexpected '='TILDE, expecting $end; Input: when using an event test for remote adjacent nodes as found in https://wiki.allstarlink.org/wiki/Event_Management

Simply adding the vars at startup (just like RPT_LINKS and RPT_NUMLINKS) addresses the issue.

Appoligies for the whitespace stripping.

Thanks to ASL2 PR by mkmer

RPT_ALINKS and RPT_NUMALINKS are not initialized at startup. Once a remote node connects/disconnects the vars become available. Until a connection, MANY errors to be logged like this:
WARNING[627] ast_expr2.fl: ast_yyerror():  syntax error: syntax error, unexpected '='TILDE, expecting $end; Input:
when using an event test for remote adjacent nodes as found in https://wiki.allstarlink.org/wiki/Event_Management

Simply adding the vars at startup (just like RPT_LINKS and RPT_NUMLINKS) addresses the issue.
Copy link
Member

@InterLinked1 InterLinked1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could fix the argument spacing, that would be great.

Trailing whitespace is not allowed in the Asterisk codebase, so that actually helps incidentally.

apps/app_rpt.c Outdated Show resolved Hide resolved
apps/app_rpt.c Outdated Show resolved Hide resolved
@InterLinked1 InterLinked1 merged commit e2931b1 into master Mar 5, 2024
2 checks passed
@tsawyer tsawyer deleted the rpt-vars branch March 22, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants